Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the environment variable used for “extra empty commit” CI-trigger token handling and changes the workflow compilation logic so the magic GH_AW_CI_TRIGGER_TOKEN secret is used by default when no explicit token is configured.
Changes:
- Renamed
GH_AW_EXTRA_EMPTY_COMMIT_TOKENtoGH_AW_CI_TRIGGER_TOKENacross workflow compilation and the JS helper/tests. - Defaulted
github-token-for-extra-empty-commitbehavior to useGH_AW_CI_TRIGGER_TOKENwhen unset/empty (while still supportingappand explicit token values). - Updated JSON schema descriptions to reflect the new defaulting behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/create_pull_request.go | Emits GH_AW_CI_TRIGGER_TOKEN env var for the create-PR job and defaults to the magic secret when not configured. |
| pkg/workflow/compiler_safe_outputs_job.go | Sets job-level GH_AW_CI_TRIGGER_TOKEN env var for consolidated safe-outputs, defaulting to the magic secret when not configured. |
| pkg/parser/schemas/main_workflow_schema.json | Updates schema text to describe the new default behavior and remove “default keyword” guidance. |
| actions/setup/js/extra_empty_commit.cjs | Reads the renamed env var (GH_AW_CI_TRIGGER_TOKEN). |
| actions/setup/js/extra_empty_commit.test.cjs | Updates tests to use the renamed env var. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@dsyme fix the lint go issues as well |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
- Fix incorrect secret name in triggering-ci.mdx magic secret section: the command showed MY_CI_TRIGGER_PAT but the correct name is GH_AW_CI_TRIGGER_TOKEN (introduced in #17997) - Add missing `runs-on` field to threat-detection.md configuration table, documenting the detection job runner override added in #17979 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GH_AW_EXTRA_EMPTY_COMMIT_TOKENenv var toGH_AW_CI_TRIGGER_TOKENacross source, tests, and schemaGH_AW_CI_TRIGGER_TOKENthe default behavior whengithub-token-for-extra-empty-commitis not explicitly configured (previously requireddefaultkeyword)